Skip to content

Add HomeSeer integration #26757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2023
Merged

Add HomeSeer integration #26757

merged 3 commits into from
Mar 31, 2023

Conversation

b-uwe
Copy link
Contributor

@b-uwe b-uwe commented Mar 28, 2023 •
edited by MartinHjelmare
Loading

Proposed change

Add a HomeSeer integration page

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Mar 28, 2023
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@b-uwe
Copy link
Contributor Author

b-uwe commented Mar 28, 2023

This clearly targets the next branch

@b-uwe b-uwe mentioned this pull request Mar 28, 2023
Merged
20 tasks
@b-uwe b-uwe marked this pull request as ready for review March 28, 2023 13:03
@b-uwe b-uwe force-pushed the homeseer_integration branch from 632d08c to 896ea24 Compare March 28, 2023 13:05
MartinHjelmare
MartinHjelmare requested changes Mar 28, 2023
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft March 28, 2023 14:33
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Mar 28, 2023
@frenck frenck added the parent-merged The parent PR has been merged already label Mar 28, 2023
MartinHjelmare
MartinHjelmare reviewed Mar 28, 2023
View reviewed changes
@b-uwe b-uwe mentioned this pull request Mar 28, 2023
Merged
11 tasks
@frenck
Copy link
Member

frenck commented Mar 29, 2023

@b-uwe You have merged the wrong branch.

@b-uwe
Copy link
Contributor Author

b-uwe commented Mar 29, 2023

@b-uwe You have merged the wrong branch.

Oh no 🤦

@b-uwe b-uwe force-pushed the homeseer_integration branch 2 times, most recently from 896ea24 to 879de48 Compare March 29, 2023 16:27
@frenck frenck added this to the 2023.4 milestone Mar 29, 2023
@b-uwe b-uwe marked this pull request as ready for review March 31, 2023 10:49
@home-assistant home-assistant bot requested a review from MartinHjelmare March 31, 2023 10:49
b-uwe and others added 3 commits March 31, 2023 12:49
@b-uwe
Add HomeSeer integration
e39be18
@b-uwe @MartinHjelmare
Apply suggestions from code review
3ccf718 
Adjust ha categories and platforms

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@b-uwe @frenck
Remove "Update" category
7dcb75f 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@b-uwe b-uwe force-pushed the homeseer_integration branch from b0adc1b to 7dcb75f Compare March 31, 2023 10:49
@b-uwe b-uwe mentioned this pull request Mar 31, 2023
Closed
8 tasks
MartinHjelmare
MartinHjelmare approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 9da22bd into home-assistant:next Mar 31, 2023
@home-assistant home-assistant bot removed parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on labels Mar 31, 2023
@b-uwe b-uwe deleted the homeseer_integration branch March 31, 2023 11:20
@b-uwe b-uwe mentioned this pull request Mar 31, 2023
Merged
8 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@b-uwe b-uwe

Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
No open projects
Documentation PRs
Archived in project
Milestone
2023.4
Development

Successfully merging this pull request may close these issues.
3 participants
@b-uwe @frenck @MartinHjelmare