Skip to content

add HTU21D sensor platform doc #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2017
Merged

add HTU21D sensor platform doc #2820

merged 3 commits into from
Jun 22, 2017

Conversation

azogue
Copy link
Member

@azogue azogue commented Jun 15, 2017

Description:

New HTU21D temperature and humidity sensor platform documentation

Pull request in home-assistant (if applicable): home-assistant/core#8049

@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Jun 16, 2017
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes are needed but looks good in general.


It will output a table like this:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't bash. Suggest you use text for highlighting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# Example configuration.yaml entry
sensor:
- platform: htu21d
name: Ambient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name can be removed from the example since it's an optional variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the customize section too to use the default root name

@fabaff fabaff dismissed Landrash’s stale review June 22, 2017 07:03

Comments addressed.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 3881bff into home-assistant:next Jun 22, 2017
@azogue azogue deleted the sensor-htu21d branch July 8, 2017 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants