-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
add BME280 sensor platform doc #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with some minor feedback.
|
||
###### Check the i2c address of the sensor | ||
|
||
If you have `sudo apt-get install i2c-tools`, you can call the i2c device detector with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some rephrasing of this sentence would be preferable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Landrash, thanks for reviewing!
What about now?
# Example configuration.yaml entry | ||
sensor: | ||
- platform: bme280 | ||
name: Ambient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name can be removed from this example since it's an optional variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and can be merged after parent PR is merged.
hi @Landrash, PRs #2820 and #2821 are related to this and share the section about the i2c install and i2c address detection. I don't know if there is another place in the doc to add these common instructions, and link in each sensor doc. In addition, I'm waiting for review for the three I2c sensors, and @fabaff was telling me about making a |
@azogue I'll review the other also. Nice to se more native support for sensors on the pi's. Have you by any chance tried this out on any of the other SOC platforms? |
Sorry @Landrash, I only have raspberries (but I have a lot!). These sensors are working smoothly in Raspberry Pi 2, RPI 3 and RPI Zero W, I could test them also in an ancient RPI 1 rev B, but I suppose it will work too. Thank you very much for your attention, btw |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🐦
Description:
Documentation for new sensor platform: BME280. It includes directions for installing the needed dependencies and more.
Pull request in home-assistant (if applicable): home-assistant/core#7989