Skip to content

add BH1750 light sensor platform doc #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2017
Merged

add BH1750 light sensor platform doc #2821

merged 4 commits into from
Jun 22, 2017

Conversation

azogue
Copy link
Member

@azogue azogue commented Jun 15, 2017 •
edited
Loading

Description:

New BH1750 light sensor platform documentation

Pull request in home-assistant (if applicable): home-assistant/core#8050

@azogue azogue mentioned this pull request Jun 15, 2017
Merged
4 tasks
@azogue azogue mentioned this pull request Jun 15, 2017
Merged
@Landrash Landrash added the new-integration This PR adds documentation for a new Home Assistant integration label Jun 16, 2017
Landrash
Landrash requested changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes are needed but looks good in general.

source/_components/sensor.bh1750.markdown Outdated

The sensor can work with resolutions of 0.5 lx (high res mode 1), 1 lx (high res mode 2) or 4 lx (low res mode), and make measurements continuously or one time each call. To set any of these operation modes, select one of these combinations: `continuous_low_res_mode`, `continuous_high_res_mode_2`, `continuous_high_res_mode_1`, `one_time_high_res_mode_1`, `one_time_high_res_mode_2`, `one_time_low_res_mode`.

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

source/_components/sensor.bh1750.markdown Outdated

It will output a table like this:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't bash. Suggest you use text for highlighting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Landrash, done!

Landrash
Landrash approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent pr is merged. 🍪

fabaff
fabaff approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

fabaff
fabaff approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 2094220 into home-assistant:next Jun 22, 2017
@azogue azogue deleted the sensor-bh1750 branch July 8, 2017 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@Landrash Landrash Landrash approved these changes

Assignees
No one assigned
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azogue @fabaff @Landrash