Skip to content

Open/Close/Stop are now optional #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2017

Conversation

PhracturedBlue
Copy link
Contributor

Description:
Align documentation with changes to cover-template to make the open_cover, close_cover, and stop_cover actions optional.

Pull request in home-assistant (if applicable): home-assistant/core#8344

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one minor comment.

- **open_cover** (*Required*): Defines an [action](/getting-started/automation/) to run when the cover is opened.
- **close_cover** (*Required*): Defines an [action](/getting-started/automation/) to run when the cover is closed.
- **stop_cover** (*Required*): Defines an [action](/getting-started/automation/) to run when the cover is stopped.
- **open_cover** (*Optional*): Defines an [action](/getting-started/automation/) to run when the cover is opened. If `open_cover` is specified, `close_cover` must also be secified. At least one of `open_cover` and `set_cover_position` must be specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled word secified
secified -> specified

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jul 5, 2017
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged after parent PR is merged 🍪

@andrey-git andrey-git merged commit 995ccf6 into home-assistant:next Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants