Skip to content

Optimistic Mode (was 'Timed cover') #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2017

Conversation

PhracturedBlue
Copy link
Contributor

@PhracturedBlue PhracturedBlue commented Jul 8, 2017

Description:
Documentation for new cover template capabilities. Adds documentation for optimistic mode and timed-movement.

Pull request in home-assistant (if applicable): home-assistant/core#8402

Note: This change is built on top of #2933

That pull request should be applied before this one.

Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged when parent PR is merged.

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jul 8, 2017
@PhracturedBlue PhracturedBlue changed the title Timed cover Optimistic Mode (was 'Timed cover') Aug 21, 2017
@PhracturedBlue
Copy link
Contributor Author

As per feedback on the patch the timed-movement code has been excised. We may in the future update the documentation with equivalent functionality using a script. The opportunistic mode code is still enabled though.

@frenck frenck merged commit 2fafa3c into home-assistant:next Aug 26, 2017
@frenck
Copy link
Member

frenck commented Aug 26, 2017

Merged, since parent PR is merged already.

Since this one is already released with 0.52, I will cherry pick this change into the current branch.

frenck pushed a commit that referenced this pull request Aug 26, 2017
* Open/Close/Stop are now optional

* typo

* Document timed-moves and optimistic mode

* Update cover.template.markdown

* Remove timed-movement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants