-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add docs for miele switches #38720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for miele switches #38720
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
❌ Deploy Preview for home-assistant-docs failed.
|
Warning Rate limit exceeded@c0ffeeca7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 29 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation for the Miele integration was updated to include new entity categories and platforms: Button, Climate, and Switch. These were added to the relevant metadata lists and detailed sections were introduced to describe their functionality. The Switch section replaces a previously mislabeled Light section, which has now been clarified and moved to its own dedicated area. The new sections explain the roles and behaviors of Button, Climate, and Switch entities, as well as the specific appliances they apply to, ensuring the documentation reflects the current platform support. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant MieleAppliance
User->>HomeAssistant: Interacts with Button/Climate/Switch entity
HomeAssistant->>MieleAppliance: Sends control command (e.g., Start, Set Temp, Power On)
MieleAppliance-->>HomeAssistant: Responds with status/update
HomeAssistant-->>User: Updates entity state in UI
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)
126-133
: Switch Section: Grammar and Consistency Improvements
A few minor refinements can enhance readability and consistency:
- Add commas for clarity in the Power description.
- Consider unifying the details summary to
"List of switch entities"
to match other sections.Proposed diff:
@@ -126,8 +126,11 @@ ### Switch -{% details "List of switches" %} +{% details "List of switch entities" %} - **Power**: The Power switch has slightly different characteristics depending on the appliance model. For some devices, it works more or less as a traditional power switch, while it behaves like a wake-up/sleep toggle on others. -The availability of the switch is controlled by the API depending on the operational state of the appliance. +The availability of the switch is controlled by the API, depending on the operational state of the appliance. {% enddetails %}🧰 Tools
🪛 LanguageTool
[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...(DURING_THAT_TIME_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/miele.markdown
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown
[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...
(DURING_THAT_TIME_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...
(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (4)
source/_integrations/miele.markdown (4)
5-10
: Categories Updated: Documentation Alignment
The new entity categories (Button
,Climate
,Switch
) have been correctly added toha_category
in alphabetical order and follow Home Assistant conventions.
18-23
: Platforms Updated: Documentation Alignment
The corresponding platforms (button
,climate
,switch
) are correctly added toha_platforms
and maintain alphabetical ordering.
90-100
: Button Section: Clarity and Consistency
The new Button entity section clearly describes the available controls and usage. It aligns well with the existing documentation conventions.
102-107
: Climate Section: Clarity and Consistency
The Climate entity section effectively documents multi-zone temperature controls. It matches the style of other entity sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)
130-130
: Consider adding a comma for clarity
In the Power switch description, inserting commas will improve readability:- For some devices it works more or less as a traditional power switch while it behaves like a wake-up/sleep toggle on others. + For some devices, it works more or less as a traditional power switch, while it behaves like a wake-up/sleep toggle on others.🧰 Tools
🪛 LanguageTool
[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...(DURING_THAT_TIME_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/miele.markdown
(3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown
[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...
(DURING_THAT_TIME_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (5)
source/_integrations/miele.markdown (5)
4-11
: Verify and approve new entity categories
Theha_category
list correctly includes the newButton
,Climate
, andSwitch
entries in alphabetical order, matching Home Assistant documentation conventions. Formatting and indentation are consistent with existing items.
17-24
: Approve new integration platforms
Theha_platforms
list now includesbutton
,climate
, andswitch
, and the entire list remains alphabetized. This aligns with platform declaration standards.
90-99
: Approve “Button” entities documentation
The Button section is well-structured under### Button
, uses a details block consistently, and clearly describes the Start, Pause, and Stop controls. Documentation style matches the rest of the integration.
102-107
: Approve “Climate” entities documentation
The Climate section follows the established pattern, clearly explains multi-zone temperature control, and uses the details block appropriately.
126-133
: Approve “Switch” entities documentation
The Switch section comprehensively covers Power, Supercooling, and Superfreezing switches, matches the formatting of other entity sections, and accurately reflects API-dependent availability.🧰 Tools
🪛 LanguageTool
[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...(DURING_THAT_TIME_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...(AI_HYDRA_LEO_MISSING_COMMA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @astrandb 👍
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit