Skip to content

Add docs for miele switches #38720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 27, 2025
Merged

Conversation

astrandb
Copy link
Contributor

@astrandb astrandb commented Apr 24, 2025

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Expanded documentation to include new Button, Climate, and Switch entity types for the Miele integration.
    • Added detailed descriptions of button controls (Start, Pause, Stop), climate controls for refrigeration appliances, and switch functions such as Power, Supercooling, and Superfreezing.
    • Clarified and reorganized the Light entity section for improved understanding.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Apr 24, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for home-assistant-docs failed.

Name Link
🔨 Latest commit 1f15ef9
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/680dd793991be200076d7dab

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 24, 2025
@astrandb astrandb marked this pull request as ready for review April 24, 2025 19:45
Copy link
Contributor

coderabbitai bot commented Apr 24, 2025

Warning

Rate limit exceeded

@c0ffeeca7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 29 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ed42fd9 and 1f15ef9.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (4 hunks)
📝 Walkthrough

Walkthrough

The documentation for the Miele integration was updated to include new entity categories and platforms: Button, Climate, and Switch. These were added to the relevant metadata lists and detailed sections were introduced to describe their functionality. The Switch section replaces a previously mislabeled Light section, which has now been clarified and moved to its own dedicated area. The new sections explain the roles and behaviors of Button, Climate, and Switch entities, as well as the specific appliances they apply to, ensuring the documentation reflects the current platform support.

Changes

File Change Summary
source/_integrations/miele.markdown Added Button, Climate, and Switch to ha_category and ha_platforms; introduced detailed sections for each; clarified and relocated Light entity documentation.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeAssistant
    participant MieleAppliance

    User->>HomeAssistant: Interacts with Button/Climate/Switch entity
    HomeAssistant->>MieleAppliance: Sends control command (e.g., Start, Set Temp, Power On)
    MieleAppliance-->>HomeAssistant: Responds with status/update
    HomeAssistant-->>User: Updates entity state in UI
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)

126-133: Switch Section: Grammar and Consistency Improvements
A few minor refinements can enhance readability and consistency:

  1. Add commas for clarity in the Power description.
  2. Consider unifying the details summary to "List of switch entities" to match other sections.

Proposed diff:

@@ -126,8 +126,11 @@
 ### Switch

-{% details "List of switches" %}
+{% details "List of switch entities" %}
 
 - **Power**: The Power switch has slightly different characteristics depending on the appliance model. For some devices, it works more or less as a traditional power switch, while it behaves like a wake-up/sleep toggle on others.
-The availability of the switch is controlled by the API depending on the operational state of the appliance.
+The availability of the switch is controlled by the API, depending on the operational state of the appliance.
 {% enddetails %}
🧰 Tools
🪛 LanguageTool

[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...

(DURING_THAT_TIME_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...

(AI_HYDRA_LEO_MISSING_COMMA)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d030ac5 and a2d7857.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown

[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...

(DURING_THAT_TIME_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...

(AI_HYDRA_LEO_MISSING_COMMA)

🔇 Additional comments (4)
source/_integrations/miele.markdown (4)

5-10: Categories Updated: Documentation Alignment
The new entity categories (Button, Climate, Switch) have been correctly added to ha_category in alphabetical order and follow Home Assistant conventions.


18-23: Platforms Updated: Documentation Alignment
The corresponding platforms (button, climate, switch) are correctly added to ha_platforms and maintain alphabetical ordering.


90-100: Button Section: Clarity and Consistency
The new Button entity section clearly describes the available controls and usage. It aligns well with the existing documentation conventions.


102-107: Climate Section: Clarity and Consistency
The Climate entity section effectively documents multi-zone temperature controls. It matches the style of other entity sections.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)

130-130: Consider adding a comma for clarity
In the Power switch description, inserting commas will improve readability:

- For some devices it works more or less as a traditional power switch while it behaves like a wake-up/sleep toggle on others.
+ For some devices, it works more or less as a traditional power switch, while it behaves like a wake-up/sleep toggle on others.
🧰 Tools
🪛 LanguageTool

[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...

(DURING_THAT_TIME_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...

(AI_HYDRA_LEO_MISSING_COMMA)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2d7857 and ed42fd9.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown

[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...

(DURING_THAT_TIME_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (5)
source/_integrations/miele.markdown (5)

4-11: Verify and approve new entity categories
The ha_category list correctly includes the new Button, Climate, and Switch entries in alphabetical order, matching Home Assistant documentation conventions. Formatting and indentation are consistent with existing items.


17-24: Approve new integration platforms
The ha_platforms list now includes button, climate, and switch, and the entire list remains alphabetized. This aligns with platform declaration standards.


90-99: Approve “Button” entities documentation
The Button section is well-structured under ### Button, uses a details block consistently, and clearly describes the Start, Pause, and Stop controls. Documentation style matches the rest of the integration.


102-107: Approve “Climate” entities documentation
The Climate section follows the established pattern, clearly explains multi-zone temperature control, and uses the details block appropriately.


126-133: Approve “Switch” entities documentation
The Switch section comprehensively covers Power, Supercooling, and Superfreezing switches, matches the formatting of other entity sections, and accurately reflects API-dependent availability.

🧰 Tools
🪛 LanguageTool

[typographical] ~130-~130: It appears that a comma is missing.
Context: ...ending on the appliance model. For some devices it works more or less as a traditional ...

(DURING_THAT_TIME_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...rks more or less as a traditional power switch while it behaves like a wake-up/sleep t...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~130-~130: Possible missing comma found.
Context: ...lity of the switch is controlled by the API depending on the operational state of t...

(AI_HYDRA_LEO_MISSING_COMMA)

@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Apr 25, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @astrandb 👍

@c0ffeeca7 c0ffeeca7 enabled auto-merge (squash) April 27, 2025 07:07
@c0ffeeca7 c0ffeeca7 merged commit 4ae7961 into home-assistant:next Apr 27, 2025
3 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Apr 27, 2025
@home-assistant home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Apr 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants