Skip to content

Improve Comelit documentation #38762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Apr 26, 2025

Proposed change

Improve Comelit documentation

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Clarified and simplified the list of supported devices and their associated entities for the Comelit SimpleHome integration.
    • Improved structure and wording for easier understanding of device-specific functionality.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 26, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link

netlify bot commented Apr 26, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit fc526c9
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/680d4541eca38b0008130913
😎 Deploy Preview https://deploy-preview-38762--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 26, 2025

📝 Walkthrough

Walkthrough

The documentation for the Comelit SimpleHome integration was revised to clarify the supported devices and their associated entities. The term "platform types" was replaced with "devices" in the Supported devices section. Device descriptions were simplified to just their names, and the Supported functionality section was reorganized to list the entities provided by each device separately, offering a clearer breakdown of features for the Comelit Serial Bridge and Comelit VEDO System.

Changes

File(s) Change Summary
source/_integrations/comelit.markdown Updated documentation to clarify supported devices and entities, simplified device descriptions, and restructured the Supported functionality section for better clarity.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation

    User->>Documentation: Reads Supported Devices section
    Documentation-->>User: Provides device names (Comelit Serial Bridge, Comelit VEDO System)

    User->>Documentation: Reads Supported Functionality section
    Documentation-->>User: Lists entities per device (e.g., climate, cover, sensors, alarm panels)
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_integrations/comelit.markdown (3)

35-38: Refine introductory wording for supported devices
Consider rephrasing to a more direct and concise statement, e.g.:

- There is support for the following devices within Home Assistant:
+ This integration supports the following devices:

This aligns with Home Assistant’s documentation style and removes unnecessary passive construction.


66-74: Enhance list formatting for device entities
To improve clarity and consistency, use plural forms and explicit entity naming. For example:

- ### Comelit Serial Bridge
- - Climate
- - Cover
- - Dehumidifier
- - Humidifier
- - Light
- - Sensor - power consumption
- - Switch - irrigation and sockets (other)
+ ### Comelit Serial Bridge
+ - Climate entities
+ - Cover entities
+ - Dehumidifier entities
+ - Humidifier entities
+ - Light entities
+ - Power consumption sensors
+ - Irrigation and socket switches

This makes each item’s type and content self-descriptive.


76-80: Apply consistent naming to VEDO System entities
Similarly, for the VEDO System section, prefer plural and clear entity descriptions:

- ### Comelit VEDO System
- - Alarm control panel - per area
- - Binary sensor - per zone presence detection
- - Sensor - per zone status
+ ### Comelit VEDO System
+ - Alarm control panel entities (one per area)
+ - Binary sensors for zone presence detection
+ - Zone status sensors

This aligns with the rest of the documentation and improves readability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d74644 and fc526c9.

📒 Files selected for processing (1)
  • source/_integrations/comelit.markdown (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @chemelli74 👍

@c0ffeeca7 c0ffeeca7 merged commit c39236c into home-assistant:current Apr 27, 2025
7 checks passed
@home-assistant home-assistant bot removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 27, 2025
@chemelli74 chemelli74 deleted the chemelli74-comelit-docs branch April 27, 2025 07:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants