-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Improve Comelit documentation #38762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Comelit documentation #38762
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Comelit SimpleHome integration was revised to clarify the supported devices and their associated entities. The term "platform types" was replaced with "devices" in the Supported devices section. Device descriptions were simplified to just their names, and the Supported functionality section was reorganized to list the entities provided by each device separately, offering a clearer breakdown of features for the Comelit Serial Bridge and Comelit VEDO System. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User->>Documentation: Reads Supported Devices section
Documentation-->>User: Provides device names (Comelit Serial Bridge, Comelit VEDO System)
User->>Documentation: Reads Supported Functionality section
Documentation-->>User: Lists entities per device (e.g., climate, cover, sensors, alarm panels)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/comelit.markdown (3)
35-38
: Refine introductory wording for supported devices
Consider rephrasing to a more direct and concise statement, e.g.:- There is support for the following devices within Home Assistant: + This integration supports the following devices:This aligns with Home Assistant’s documentation style and removes unnecessary passive construction.
66-74
: Enhance list formatting for device entities
To improve clarity and consistency, use plural forms and explicit entity naming. For example:- ### Comelit Serial Bridge - - Climate - - Cover - - Dehumidifier - - Humidifier - - Light - - Sensor - power consumption - - Switch - irrigation and sockets (other) + ### Comelit Serial Bridge + - Climate entities + - Cover entities + - Dehumidifier entities + - Humidifier entities + - Light entities + - Power consumption sensors + - Irrigation and socket switchesThis makes each item’s type and content self-descriptive.
76-80
: Apply consistent naming to VEDO System entities
Similarly, for the VEDO System section, prefer plural and clear entity descriptions:- ### Comelit VEDO System - - Alarm control panel - per area - - Binary sensor - per zone presence detection - - Sensor - per zone status + ### Comelit VEDO System + - Alarm control panel entities (one per area) + - Binary sensors for zone presence detection + - Zone status sensorsThis aligns with the rest of the documentation and improves readability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/comelit.markdown
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @chemelli74 👍
Proposed change
Improve Comelit documentation
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit