Update USPS docs to include required driver declaration #4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes to the USPS component in #12465 we're now required to specify the `driver` regardless if using `phantomjs` or `chrome`. Updating docs to reflect the required `driver: phantomjs` if using it. Re: * happyleavesaoc/python-myusps#11 * home-assistant/core#12465
|
The intention was for This doc change is reasonable in the interim. |
|
@happyleavesaoc Yeah, agreed. Thought this would help clarify things for now. Not sure why HA isn't defaulting to |
|
Can you specify the installation reference for phantomjs on raspberry pi? It is listed that the apt-get version is not compatible. Not sure what version is and what installation method is preferred or needed. Thanks! |
frenck
approved these changes
Mar 14, 2018
|
@brianjking Thank you for adding this to the docs! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the changes to the USPS component in #12465 we're now required to specify the
driverregardless if usingphantomjsorchrome. Updating docs to reflect the requireddriver: phantomjsif using it.Re:
Pull request in home-assistant (if applicable): home-assistant/core#12465
Checklist:
current. New documentation for platforms/components and features should go tonext.