Skip to content

Create component page for mysensors based cover #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 1, 2016
Merged

Create component page for mysensors based cover #986

merged 6 commits into from
Oct 1, 2016

Conversation

OttoWinter
Copy link
Member

@OttoWinter OttoWinter commented Sep 25, 2016

@OttoWinter
Copy link
Member Author

Currently, the example sketch for MySensors covers is written for MySensors v2.0, whereas all other home-assistant.github.io MySensors pages are written for v1.5. In MySensors-land, v2.0 seems to be where all the cool new stuff is happening right now. I could, however, easily port the example to v1.5, if that was required.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, otherwise looks good.

pinMode(COVER_DOWN_SENSOR_PIN, INPUT);

// Send initial values.
sendState();
Copy link
Member

@MartinHjelmare MartinHjelmare Sep 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In mysensors 2.0.0 this has to be done in the loop, due to registration on gateway required before device can send values. This has changed in dev branch of mysensors, but that's not released yet.

```

[main component]: /components/mysensors/
[serial api]: https://www.mysensors.org/download/serial_api_15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is not working anymore, cause they removed that site. Use API 2.0 instead:
https://www.mysensors.org/download/serial_api_20

@MartinHjelmare
Copy link
Member

I think it's good to add example sketches for version 2.0 from now on and rather complement the existing sketches with ones for version 2.0. So no need to change that.

@OttoWinter
Copy link
Member Author

@MartinHjelmare I just realised that I have set ha_release in the header section to 0.29. This should probably be updated when the PR is merged.

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Sep 29, 2016

Yes! Change it to 0.30.

footer: true
logo: mysensors.png
ha_category: Cover
ha_release: 0.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature has been merged so change ha_release to 0.30.

@MartinHjelmare MartinHjelmare merged commit 2fffb5d into home-assistant:next Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants