-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Create component page for mysensors based cover #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, the example sketch for MySensors covers is written for MySensors v2.0, whereas all other home-assistant.github.io MySensors pages are written for v1.5. In MySensors-land, v2.0 seems to be where all the cool new stuff is happening right now. I could, however, easily port the example to v1.5, if that was required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments, otherwise looks good.
pinMode(COVER_DOWN_SENSOR_PIN, INPUT); | ||
|
||
// Send initial values. | ||
sendState(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In mysensors 2.0.0 this has to be done in the loop, due to registration on gateway required before device can send values. This has changed in dev branch of mysensors, but that's not released yet.
``` | ||
|
||
[main component]: /components/mysensors/ | ||
[serial api]: https://www.mysensors.org/download/serial_api_15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is not working anymore, cause they removed that site. Use API 2.0 instead:
https://www.mysensors.org/download/serial_api_20
I think it's good to add example sketches for version 2.0 from now on and rather complement the existing sketches with ones for version 2.0. So no need to change that. |
@MartinHjelmare I just realised that I have set |
Yes! Change it to 0.30. |
footer: true | ||
logo: mysensors.png | ||
ha_category: Cover | ||
ha_release: 0.29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature has been merged so change ha_release
to 0.30.
See home-assistant/core#3512