Update name checking #1083
Update name checking #1083
Conversation
Allow characters in names to match what Home app ACTUALLY supports
There was a problem hiding this comment.
Happy with these changes.
Out of interest: what character is \u2019?
However, I still think the name check should be a skipped for DisplayName on an InputSource service for a TV accessory. For this service, DisplayName doesn’t seem to be linked to the service name.
unicode right apostrophe |
|
Chop chop.. Lets get moving on approvals and get this implemented |
|
@n0rt0nthec4t Erik already approved it last week, you should be good to merge? |
Understood it needed all 11 reviewers to approve as says 10 still outstanding? I dont have access to merge ;-) |
|
@n0rt0nthec4t ah I see. I believe the rule just needs one review. I thought after it's approved everyone can hit the merge button. Guess that's not the case 😅 Now it's merged, thanks for the PR 🙏 |
Updated name checking to allow names with characters in with the Home app actually supports