Skip to content

Add explanation for caching pattern #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Conversation

iluwatar
Copy link
Owner

Continues the epic quest 🐉 of explaining each and all of the patterns #590. In this PR:

  • Add explanation for caching pattern
  • Light refactoring to update logging code

I think I'll also create a follow-up issue with some ideas about improving the code quality in this pattern.

@iluwatar iluwatar requested a review from ohbus March 28, 2021 09:58
@ohbus ohbus self-assigned this Mar 28, 2021
Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement @iluwatar

Thanks for the changes!

@ohbus ohbus merged commit eb8f9db into master Mar 28, 2021
@ohbus
Copy link
Contributor

ohbus commented Mar 28, 2021

@iluwatar I messed adding the prefix tag as well. Sorry.

@ohbus ohbus added this to the 1.24.0 milestone Mar 28, 2021
@iluwatar
Copy link
Owner Author

It's hard to remember every time. Would there be a technical solution helping us remember it? Git pre-commit hook or something...?

@iluwatar iluwatar deleted the caching-pattern-explanation branch December 30, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants