Skip to content

[Bug] isPlainObj fn not compatible for IE11 #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
binarykitchen opened this issue Oct 31, 2019 · 2 comments · Fixed by #1833
Closed

[Bug] isPlainObj fn not compatible for IE11 #1745

binarykitchen opened this issue Oct 31, 2019 · 2 comments · Fixed by #1833
Labels
bug
Milestone
4.0

Comments

@binarykitchen
Copy link

This implementation is breaking on IE11

  function isPlainObj(value) {
    return (
      value &&
      (typeof value.constructor !== 'function' ||
        value.constructor.name === 'Object')
    );
  }

Always returns false.

Refer to https://stackoverflow.com/questions/25140723/constructor-name-is-undefined-in-internet-explorer
@binarykitchen
Copy link
Author

A workaround would be to polyfill that with

  if ('name' in Object.constructor.prototype === false) {
    Object.defineProperty(Object.constructor.prototype, 'name', {
      get: function () {
        return this.toString().trim().replace(/^\S+\s+(\w+)[\S\s]+$/, '$1')
      }
    })
  }

@Methuselah96 Methuselah96 mentioned this issue Oct 17, 2020
Closed
@Methuselah96 Methuselah96 mentioned this issue Nov 14, 2020
Closed
@Methuselah96 Methuselah96 added this to the 4.0 milestone Jun 18, 2021
@jdeniau jdeniau linked a pull request Jun 29, 2021 that will close this issue
Integrate immutable-js-oss fork into main repository #1833
Merged
3 tasks
@jdeniau
Copy link
Member

jdeniau commented Jun 29, 2021

Thank you for your bug report. The immutable-js oss fork will soon be merged and a fix for this issue has been included in #1833. Once this PR is merged, this issue will be resolved in the main branch. We will then do our best to to release the 4.0.0 version.

Commit reference: f3a6d5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Integrate immutable-js-oss fork into main repository immutable-js/immutable-js
3 participants
@binarykitchen @Methuselah96 @jdeniau