Skip to content

Improve type infererence for fromJS #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

KSXGitHub
Copy link
Contributor

@KSXGitHub KSXGitHub commented Oct 10, 2018

With this pull request, fromJS(value) will no longer return any.

Broken test: This does not work in TypeScript 2.2, so I upgrade dtslint, which breaks linter. I don't want to mess with files that are not related to the change, so I reverted my attempt in fixing linter.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron
Copy link
Collaborator

Awesome, thanks for doing this. Let's get TypeScript updated to prove support for 3.0 so this can be merged

@jdeniau
Copy link
Member

jdeniau commented Feb 3, 2023

Superseded by #1927

Thanks @KSXGitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants