Skip to content

check 5.x #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 71 commits into from
Oct 17, 2024
Merged

check 5.x #2011

merged 71 commits into from
Oct 17, 2024

Conversation

jdeniau
Copy link
Member

@jdeniau jdeniau commented Aug 1, 2024

Create a PR to check that all 5.0.0 code is OK before merging in main.

jdeniau and others added 30 commits August 24, 2023 12:02
Co-authored-by: Michael Bullington <michael.bullington@mapbox.com>
…g modules (#1888)

Co-authored-by: Taylor Clay <tclay@atlassian.com>
Co-authored-by: Julien Deniau <julien.deniau@gmail.com>
* Upgrade eslint and ignore no-constructor-return rule for actual constructors (#1974)

* Upgrade eslint and ignore no-constructor-return rule for actual constructors

* ignore eslint-next for now

* upgrate documentation website to next 14 (#1975)

* upgrate to next 12

* next 13

* migrate links

* next 14

* deactivate eslint for documentation once again

* Fix title warning. See vercel/next.js#38256

* start migrating to nextjs app router (#1976)

* upgrade next sitemap (#1978)
* replace tslint by typescript-eslint

* remove tslint config file and comments

* Fix  eslint issue in src directory

* Migrate simple eslint rules in __test__ directory

* use stricter types in __tests__ directory

* Fix or ignore all eslint issues in website directory

* Ignore eslint report in main immutable.d.ts file for now
@jdeniau
Copy link
Member Author

jdeniau commented Aug 1, 2024

Hi @leebyron ,

I'd like to merge this huge 5.x branch, but I'd like not to squash all this (it contains links to PR etc.)
Could you please allow "create a merge commit" in the repository administration?

image

I did allow "Allow merge commits" and "Allow rebase merging" in the "general" settings, but the "merge" option is still disabled in the PR.

image

I tried merging in command line too, but I got:

remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: This branch must not contain merge commits

Thank you.

@iambumblehead
Copy link

Thank you for this great package. The rollup process generates minified and un-minified "umd" modules that are less useful these days. Please consider exporting minified esm instead.

@jdeniau
Copy link
Member Author

jdeniau commented Sep 17, 2024

Hi @iambumblehead

Theoretically, the "module" key of package.json does target an ESM build.

I'm not really confident with releasing a non-umd build as there is a lot of users of immutable.
Maybe for the 6.x, but it will probably need a long "beta" time to have feedback from the users.

@jdeniau jdeniau merged commit 2898646 into main Oct 17, 2024
10 checks passed
@jdeniau jdeniau deleted the 5.x branch October 17, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants