Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Add CQs management methods to the client #414

Merged
merged 6 commits into from
Apr 8, 2020

Conversation

smolse
Copy link
Contributor

@smolse smolse commented Feb 11, 2017

This PR adds to the client new methods which allow create, show and drop continuous queries in InfluxDB more easily.

@smolse smolse force-pushed the cqs-methods branch 2 times, most recently from f93a9a0 to 4e42b41 Compare February 11, 2017 20:15
@smolse
Copy link
Contributor Author

smolse commented Feb 12, 2017

@aviau seems like docs test is really broken.

@aviau
Copy link
Collaborator

aviau commented Feb 21, 2017

seems like docs test is really broken.

Yeah. Somebody needs to fix it.

@aviau
Copy link
Collaborator

aviau commented Mar 1, 2017

Can you rebase this on master? The tests should now pass.

@smolse
Copy link
Contributor Author

smolse commented Mar 2, 2017

Yay, it is passing now.

@sebito91
Copy link
Contributor

@smolse the logic here is completely fine, but can you please add comments to the test functions (something basic)? We've introduced PEP257 compliance over the past few weeks, and that's the only failing test at the moment.

Once you've added, we can merge this.

Copy link
Contributor

@sebito91 sebito91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP257 compliance for test cases

@sebito91 sebito91 assigned sebito91 and smolse and unassigned sebito91 Aug 17, 2017
@lukaszdudek-silvair
Copy link
Contributor

@smolse - do you intend to work on this anytime soon?
AFAIU the thing to be done (apart from rebasing on master again) is to add docstrings to test cases - is that right, @sebito91 ?

@sebito91 sebito91 requested review from aviau and xginn8 as code owners April 8, 2020 21:13
@sebito91 sebito91 merged commit a368951 into influxdata:master Apr 8, 2020
ocworld pushed a commit to AhnLab-OSS/influxdb-python that referenced this pull request Apr 13, 2020
* Add CQs management methods to the client

* chore(server_tests): update pep257 and flake8 commentary

* chore(client_test): update comments based on pep257 and flake8

Co-authored-by: Sergei Smolianinov <sergei.smolianinov@f-secure.com>
Co-authored-by: Sebastian Borza <sebito91@gmail.com>
Co-authored-by: xginn8 <xginn8@users.noreply.github.com>
ocworld pushed a commit to AhnLab-OSS/influxdb-python that referenced this pull request Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants