This repository was archived by the owner on Oct 29, 2024. It is now read-only.
fix: Calling commit and _json_body make raising an exception when any datapoints are not added. #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es raising an exception because _datapoints is not allocated. It is hard to find the reason of this error. it is because reviewing influxdb-python's code is needed. I think that it is important that is producing predictable results. Results when calling first time is needed to equal to calling resetting datapoints in json_body. So, I've fixed that if not initialized when calling _json_body() function, _datapoints is reset to avoid raising error. In Unittest, the setup function is added. When calling setup function firstly, __initialized__ is False and _datapoints is not assigned. But, because of this commit, it is OK. Contacts: Keunhyun Oh <keunhyun.oh@ahnlab.com>
added 6 commits
December 6, 2019 00:41
Contacts: Keunhyun Oh <keunhyun.oh@ahnlab.com>
Contacts: Keunhyun Oh <keunhyun.oh@ahnlab.com>
Contacts: Keunhyun Oh <keunhyun.oh@ahnlab.com>
ocworld
added a commit
to AhnLab-OSS/influxdb-python
that referenced
this pull request
Apr 13, 2020
… datapoints are not added. (influxdata#772) * If any SerialHelper is not generated, calling the commit function makes raising an exception because _datapoints is not allocated. It is hard to find the reason of this error. it is because reviewing influxdb-python's code is needed. I think that it is important that is producing predictable results. Results when calling first time is needed to equal to calling resetting datapoints in json_body. So, I've fixed that if not initialized when calling _json_body() function, _datapoints is reset to avoid raising error. In Unittest, the setup function is added. When calling setup function firstly, __initialized__ is False and _datapoints is not assigned. But, because of this commit, it is OK. Contacts: Keunhyun Oh <keunhyun.oh@ahnlab.com> * fix build fail Contacts: Keunhyun Oh <keunhyun.oh@ahnlab.com> * fix build fail Contacts: Keunhyun Oh <keunhyun.oh@ahnlab.com> * fix build fail Contacts: Keunhyun Oh <keunhyun.oh@ahnlab.com> * Update helper_test.py * Update helper_test.py * Update helper_test.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any SerialHelper is not generated, calling the commit function makes raising an exception because _datapoints is not allocated.
It is hard to find the reason of this error. it is because reviewing influxdb-python's code is needed.
I think that it is important that is producing predictable results. Results when calling first time is needed to equal to calling resetting datapoints in json_body.
So, I've fixed that if not initialized when calling _json_body() function, _datapoints is reset to avoid raising error.
In Unittest, the setup function is added. When calling setup function firstly, initialized is False and _datapoints is not assigned. But, because of this commit, it is OK.
Contacts: Keunhyun Oh keunhyun.oh@ahnlab.com
Contributor checklist