Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

fix: Calling commit and _json_body make raising an exception when any datapoints are not added. #772

Merged
merged 7 commits into from
Apr 10, 2020
Merged

fix: Calling commit and _json_body make raising an exception when any datapoints are not added. #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1ab4be5
If any SerialHelper is not generated, calling the commit function mak…
Dec 5, 2019
952e13f
fix build fail
Dec 5, 2019
53b1129
fix build fail
Dec 5, 2019
f3d2a90
fix build fail
Dec 5, 2019
f0845cf
Update helper_test.py
Dec 6, 2019
a02c46a
Update helper_test.py
Dec 6, 2019
0362f73
Update helper_test.py
Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions influxdb/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ def _json_body_(cls):
:return: JSON body of these datapoints.
"""
json = []
if not cls.__initialized__:
cls._reset_()
for series_name, data in six.iteritems(cls._datapoints):
for point in data:
json_point = {
Expand Down
2 changes: 2 additions & 0 deletions influxdb/influxdb08/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ def _json_body_(cls):
:return: JSON body of the datapoints.
"""
json = []
if not cls.__initialized__:
cls._reset_()
for series_name, data in six.iteritems(cls._datapoints):
json.append({'name': series_name,
'columns': cls._fields,
Expand Down
8 changes: 8 additions & 0 deletions influxdb/tests/helper_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ class Meta:

TestSeriesHelper.MySeriesHelper = MySeriesHelper

def setUp(self):
"""Check that MySeriesHelper has empty datapoints."""
super(TestSeriesHelper, self).setUp()
self.assertEqual(
TestSeriesHelper.MySeriesHelper._json_body_(),
[],
'Resetting helper in teardown did not empty datapoints.')

def tearDown(self):
"""Deconstruct the TestSeriesHelper object."""
super(TestSeriesHelper, self).tearDown()
Expand Down