Allow values of custom attributes to be None. #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @neocortex. I followed the same rules as the official Ruby wrapper. I'll ask them why they preclude None/nil. I don't see a reason not to. @maiiku has merged this change into his PR. |
|
Fixed and now in version 2.0, available from PyPi. See 8ca7d74 for the change and tests. Thanks again, I've added your profile to the AUTHORS page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have
Nonevalues in custom attributes of a company in Intercom (named 'UNKNOWN' in Intercom). Trying to find or create a company (e.g.Company. find(company_id='bla') gives a ValueError, complaining that custom data can only be numbers or strings. Afaik, Intercom does simply not allow nested values (and I guess that is what the flat_store functionality is supposed to be for).This PR is to also allow null values in custom attributes. Unittests pass, and I have no problems with interacting with intercom using Nones.