Skip to content

parseUnifiedDiff exception on valid diff (Binary files) #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
machadoit opened this issue Feb 6, 2024 · 0 comments
Closed

parseUnifiedDiff exception on valid diff (Binary files) #182

machadoit opened this issue Feb 6, 2024 · 0 comments

Comments

@machadoit
Copy link
Contributor

Describe the bug
com.github.difflib.unifieddiff.UnifiedDiffReader#parseUnifiedDiff fails when the diff contains changes with Binaries.

To Reproduce

  1. Consider a diff with Binary changes, like adding a new test problem_diff_binary.diff with:
diff --git a/some-image.png b/some-image.png
new file mode 100644
index 0000000..bc3b5b4
Binary files /dev/null and b/some-image.png differ
  1. Invoke com.github.difflib.unifieddiff.UnifiedDiffReader#parseUnifiedDiff like a new test:
    @Test
    public void testParseBinary() throws IOException {
        UnifiedDiff diff = UnifiedDiffReader.parseUnifiedDiff(
                UnifiedDiffReaderTest.class.getResourceAsStream("problem_diff_binary.diff"));

        assertEquals(1, 1);
    }

By doing so, it returns an exception:

com.github.difflib.unifieddiff.UnifiedDiffReader processLine WARNING: >>> no rule matched Binary files /dev/null and b/some-image.png differ

Expected behavior
I would expect not to throw an exception, and that it would handle the Binary file entry as an UnifiedDiffFile

System
openjdk 17 2021-09-14
OpenJDK Runtime Environment Temurin-17+35 (build 17+35)
OpenJDK 64-Bit Server VM Temurin-17+35 (build 17+35, mixed mode, sharing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant