Skip to content

Fixes #182 by parsing diffs with 'Binary files' #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

machadoit
Copy link
Contributor

Adds fix for #182 by parsing diff lines that start with 'Binary files'

@machadoit
Copy link
Contributor Author

Names like testParseIssue182_add are getting flagged by Codacy, do change them to your standards, or let me know if you would like to change them. Thanks!

@machadoit
Copy link
Contributor Author

In the meanwhile, after some more testing, and checking the fields of fromFile and toFile, there seems there is already a bug on diff blocks that don't have any changes or something like that? https://github.com/java-diff-utils/java-diff-utils/pull/184/files

This change also suffers from the same bug, and will consume more lines that it should as part of the binary file block

@wumpz wumpz merged commit 54324fb into java-diff-utils:master Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants