-
Notifications
You must be signed in to change notification settings - Fork 9
Comparisons #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparisons #81
Conversation
@ArMinasyan thanks for the PR. I'll review it until Monday. |
1-js/02-first-steps/09-comparison/1-comparison-questions/task.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/09-comparison/1-comparison-questions/task.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the required changes. Thanks. I'll continue my review tomorrow.
1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/09-comparison/1-comparison-questions/task.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md
Outdated
Show resolved
Hide resolved
Please make the requested changes. After it, add a comment "/done". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't be discouraged by the number of comments. It is OK for the first time contributing to this project. Once all the required changes are implemented I'll go through the PR again. Thanks for your great effort!
Please make the requested changes. After it, add a comment "/done". |
@ArMinasyan thanks for the changes. Couple of things to note. Please do not resolve conversations. Maintainers/reviewers will take care of that. Also when ready to request a new review from a maintainer just add a comment as follows:
Our bot will then take care of notifying appropriate people and will re-request a review. Thanks. |
@ArMinasyan we're generally getting closer to merging this PR. I'll give it another round of review after you fix all formatting issues (like missing or having extra new lines) and typos. Thank you. |
done |
@ArMinasyan any progress on this PR? Do you need any help or clarification? Thanks. |
Nope, I will review the changes again |
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
@ArMinasyan I've fixed a few things and merged your PR. Thanks for your contribution! |
No description provided.