Skip to content

Comparisons #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 21, 2021
Merged

Comparisons #81

merged 7 commits into from
Aug 21, 2021

Conversation

ArMinasyan
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2021

CLA assistant check
All committers have signed the CLA.

@bugron bugron changed the title Comparison Comparisons Jul 31, 2021
@bugron
Copy link
Contributor

bugron commented Jul 31, 2021

@ArMinasyan thanks for the PR. I'll review it until Monday.
One tiny note for now. PR titles should exactly match article names as specified in #1. That way our bot will automatically edit that issue's description so we can track which article is translated in which PR.

Copy link
Contributor

@bugron bugron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the required changes. Thanks. I'll continue my review tomorrow.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Copy link
Contributor

@bugron bugron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't be discouraged by the number of comments. It is OK for the first time contributing to this project. Once all the required changes are implemented I'll go through the PR again. Thanks for your great effort!

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ArMinasyan ArMinasyan requested a review from bugron August 1, 2021 06:50
@bugron
Copy link
Contributor

bugron commented Aug 1, 2021

@ArMinasyan thanks for the changes. Couple of things to note. Please do not resolve conversations. Maintainers/reviewers will take care of that. Also when ready to request a new review from a maintainer just add a comment as follows:

/done

Our bot will then take care of notifying appropriate people and will re-request a review. Thanks.

@bugron
Copy link
Contributor

bugron commented Aug 1, 2021

@ArMinasyan we're generally getting closer to merging this PR. I'll give it another round of review after you fix all formatting issues (like missing or having extra new lines) and typos. Thank you.

@ArMinasyan
Copy link
Contributor Author

done

@bugron
Copy link
Contributor

bugron commented Aug 13, 2021

@ArMinasyan any progress on this PR? Do you need any help or clarification? Thanks.

@ArMinasyan
Copy link
Contributor Author

Nope, I will review the changes again

@bugron bugron merged commit 7675123 into javascript-tutorial:master Aug 21, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@bugron
Copy link
Contributor

bugron commented Aug 21, 2021

@ArMinasyan I've fixed a few things and merged your PR. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants