Skip to content

Breaking Changes for 0.4.0 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2020
Merged

Breaking Changes for 0.4.0 #68

merged 7 commits into from
Apr 23, 2020

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Apr 21, 2020

A couple breaking changes necessary to protect against memory attacks, thrown in some long overdue ones as well.

  • images larger than 100 megapixels or requiring more than 512MB of memory to decode will throw unless maxMemoryUsageInMB and maxResolutionInMP options are increased
  • drop decode boolean second argument, options must be an object
  • no longer support node versions before 8 LTS
  • enable tolerantDecoding by default

BREAKING CHANGE: no longer support node versions before 8 LTS
BREAKING CHANGE: drop decode boolean second argument, options must be an object
BREAKING CHANGE: images larger than 100 megapixels or requiring more than 512MB of memory to decode will throw unless `maxMemoryInMB` and `maxResolutionInMP` options are increased
@eugeneware
Copy link
Collaborator

@patrickhulce I like where this is going - where you can specify a memory limit and override it. Looking great!

@patrickhulce
Copy link
Collaborator Author

Thanks @eugeneware! Btw, do you know what's up with the Travis status failing to post on PRs/commits these days? I can't really investigate since I'm not the repo owner.

@patrickhulce
Copy link
Collaborator Author

patrickhulce commented Apr 22, 2020

Ah so the Travis issue might be a result of some of the problems they're having (intentionally?) with "legacy" Travis configurations. We might want to migrate https://travis-ci.com/account/migrate

@eugeneware
Copy link
Collaborator

LGTM 👏 - Good to merge and deploy @patrickhulce

@eugeneware
Copy link
Collaborator

@patrickhulce - I had a quick look into the travis-ci stuff. I've kicked off the migration to the new system. It's still not showing up, so not sure how long the migration takes, or if their migration process is broken. If it does work we might need to update the build status badges to go against the .com vs .org links.

@patrickhulce patrickhulce merged commit 78408c6 into master Apr 23, 2020
@patrickhulce patrickhulce deleted the breaking_change branch April 23, 2020 13:59
@patrickhulce
Copy link
Collaborator Author

published 0.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants