-
Notifications
You must be signed in to change notification settings - Fork 124
Breaking Changes for 0.4.0 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: no longer support node versions before 8 LTS
BREAKING CHANGE: drop decode boolean second argument, options must be an object
BREAKING CHANGE: images larger than 100 megapixels or requiring more than 512MB of memory to decode will throw unless `maxMemoryInMB` and `maxResolutionInMP` options are increased
91488ea
to
60e2647
Compare
@patrickhulce I like where this is going - where you can specify a memory limit and override it. Looking great! |
Thanks @eugeneware! Btw, do you know what's up with the Travis status failing to post on PRs/commits these days? I can't really investigate since I'm not the repo owner. |
Ah so the Travis issue might be a result of some of the problems they're having (intentionally?) with "legacy" Travis configurations. We might want to migrate https://travis-ci.com/account/migrate |
LGTM 👏 - Good to merge and deploy @patrickhulce |
@patrickhulce - I had a quick look into the travis-ci stuff. I've kicked off the migration to the new system. It's still not showing up, so not sure how long the migration takes, or if their migration process is broken. If it does work we might need to update the build status badges to go against the .com vs .org links. |
published 0.4.0 🎉 |
A couple breaking changes necessary to protect against memory attacks, thrown in some long overdue ones as well.
maxMemoryUsageInMB
andmaxResolutionInMP
options are increased