Skip to content

Plugin download tracker JS #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

joshuacc
Copy link

I'm not yet sure how this should be included in the plugins download page. My guess is that there should be something in plugins.jquery.com/functions.php to include the script, but it's been a while since I hacked on WordPress. If someone can point me in the right direction, I'll be happy to finish that up. :-)

nacin and others added 6 commits October 15, 2012 13:36
Updated to ensure overrides are enabled for <VirtualHost> entry
Needed if overrides are disabled by default so the .htaccess file rules are honored
Not yet sure how this should be included in the plugins download page.
@jzaefferer
Copy link
Member

@rxaviers @rdworth who's working on the plugins site and can review this?

@rxaviers
Copy link
Member

Adding @dnschnur...

@nacin
Copy link
Member

nacin commented Oct 16, 2012

In functions.php:

add_action( 'wp_enqueue_scripts', function() {
    wp_register_script( 'jquery-plugin-download', get_stylesheet_directory_uri() . '/js/tracker.js', array(), null, true );

});

@nacin
Copy link
Member

nacin commented Oct 16, 2012

And at the top of content-jquery_plugin.php:

wp_enqueue_script( 'jquery-plugin-download' );

Attached the WP functions to pull the tracker JS file in.
@joshuacc
Copy link
Author

I've added the WordPress code as mentioned by @nacin. I think this is ready to go.

@scottgonzalez
Copy link
Member

@joshuacc Can you rebase this? There are some seemingly random commits mixed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants