-
Notifications
You must be signed in to change notification settings - Fork 480
Remove Javascript 101 section #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -10,3 +10,5 @@ | |||
}</script> | |||
|
|||
Getting started with jQuery can be easy or challenging, depending on your experience with JavaScript, HTML, CSS, and programming concepts in general. In addition to these articles, you can read about the [history of jQuery](https://jquery.org/history/) and the [licensing terms](https://jquery.org/license/) that apply to jQuery projects. You can also [make a donation](https://jquery.org/donate/) to help the [jQuery team](https://jquery.org/team/) continue to improve jQuery. | |||
|
|||
One important thing to know is that jQuery is just a __JavaScript library__. All the power of jQuery is accessed via JavaScript, so needless to say, it's an important language to learn. Having a basic knowledge of JavaScript will go a long way in understanding, structuring, and debugging your code. If you're new to JavaScript we recommend to check out [the JavaScript basics tutorial on MDN](https://developer.mozilla.org/en-US/Learn/Getting_started_with_the_web/JavaScript_basics). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since "MDN" is a new initialism to folks, I'd recommend expanding it to "Mozilla Developer Network". I think the "All the power...language to learn" sentence is superfluous, but i'll defer to the actual content writers on that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @danheberden. Updating PR right now.
@@ -10,3 +10,5 @@ | |||
}</script> | |||
|
|||
Getting started with jQuery can be easy or challenging, depending on your experience with JavaScript, HTML, CSS, and programming concepts in general. In addition to these articles, you can read about the [history of jQuery](https://jquery.org/history/) and the [licensing terms](https://jquery.org/license/) that apply to jQuery projects. You can also [make a donation](https://jquery.org/donate/) to help the [jQuery team](https://jquery.org/team/) continue to improve jQuery. | |||
|
|||
One important thing to know is that jQuery is just a __JavaScript library__. All the power of jQuery is accessed via JavaScript, so needless to say, it's an important language to learn. Having a basic knowledge of JavaScript will go a long way in understanding, structuring, and debugging your code. If you're new to JavaScript we recommend to check out the [JavaScript basics tutorial](https://developer.mozilla.org/en-US/Learn/Getting_started_with_the_web/JavaScript_basics) on the Mozilla Developer Network (MDN). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps link to https://www.khanacademy.org/computing/computer-programming as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that Khan is a super resource, but the thing is that there are that many good resources over on the internet. Isn't it better for beginners to just start reading one good thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with it either way. Maybe you're right, if we pick one people won't be inclined to pile on a bunch of PRs to add to a big list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Than we could as well add this hole list :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "important language to learn" kind of understates the importance. People constantly complain that jQuery is "the reason people don't really know JavaScript - this paragraph should be the thing where we state that we actually do feel like some command of JS is essentially a "prerequisite" for being effective with jQuery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about replacing this:
so needless to say, it's an important language to learn. Having a basic knowledge of JavaScript will go a long way
with this:
so strong knowledge of JavaScript is important in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like @dmethvin's change. Here is what the paragraph would look like (with a couple minor tweaks added from me):
One important thing to know is that jQuery is just a JavaScript library. All the power of jQuery is accessed via JavaScript, so having a strong grasp of JavaScript is essential for understanding, structuring, and debugging your code. If you're new to JavaScript, we recommend checking out the JavaScript basics tutorial on the Mozilla Developer Network (MDN).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole line was taken from javascript-101.md
, but I agree the version above is better. Updated PR to @kswedberg's version.
LGTM |
@ajpiano Other than that sentence, you like this solution/PR? I'm just interested in hearing your thoughts. |
I think we don't necessarily have to kill this section but I understand why we're doing it so 👍 . I think we could stand to bikeshed that language a little longer but in a separate pass, perhaps. OTOH, what do you think of adding a sentence like this... "All the power of jQuery is accessed via JavaScript, so having a strong grasp of JavaScript is essential for understanding, structuring, and debugging your code. While working with jQuery regularly can, over time, improve your proficiency with JavaScript, it can be hard to get started writing jQuery without a working knowledge of the JavaScript's built-in constructs and syntax. Therefore, If you're new to JavaScript, we recommend checking out the JavaScript basics tutorial on the Mozilla Developer Network (MDN)." |
I think @ajpiano's version is better, except "knowledge of the JavaScript's…" should be "knowledge of JavaScript's…" |
I think @ajpiano's version is better, except "knowledge of the JavaScript's…" should be "knowledge of JavaScript's…" I just updated the PR. |
Well then I think we're ready to merge this one. I'll do it this evening if nobody disagrees. |
Changes:
about-jquery.md
to express it's important to know at least a little of 'raw' JavaScript.JavaScript Basics
articles on MDN, to point people in the right direction. First I was planning to link up more than one resource, but MDN has it all.js-basics
label + Replace JavaScript 101 Section with MDN information using Kuma API #257 itself.