Skip to content

Ignore elements that belong to other/nested forms #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2018
Merged

Ignore elements that belong to other/nested forms #2147

merged 2 commits into from
Mar 4, 2018

Conversation

Arkni
Copy link
Member

@Arkni Arkni commented Mar 4, 2018

No description provided.

@Arkni Arkni mentioned this pull request Mar 4, 2018
Closed
@Arkni
Copy link
Member Author

Arkni commented Mar 4, 2018

Note to self: Need to fix the case described in #2035 as this PR only ignores the elements when submitting the form or when validating it directly using either $(form).valid(), validator.form() or validator.checkForm().

@Arkni Arkni force-pushed the ignore-other-forms-elements branch from c0f1bf1 to 1096356 Compare March 4, 2018 12:32
@Arkni Arkni force-pushed the ignore-other-forms-elements branch from 1096356 to fcdf856 Compare March 4, 2018 13:12
@Arkni
Copy link
Member Author

Arkni commented Mar 4, 2018

Fixed the issue mentionned in my previous comment.
This PR is good to go now.

@Arkni Arkni added the Core label Mar 4, 2018
@Arkni Arkni merged commit a355a0f into jquery-validation:master Mar 4, 2018
@Arkni Arkni deleted the ignore-other-forms-elements branch March 4, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm approved these changes

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkni @staabm