Nis br method review #2204
Nis br method review #2204
Conversation
Fixes new implementation Fixes jquery-validation#2169
File commited wrong
Fixes new implementation Fixes jquery-validation#2196
…validation into nis-br-method
Nis br method
Rewrite with reviews some mistakes Fixes jquery-validation#2203
Rewrite with reviews some mistakes Fixes jquery-validation#2203
…jquery-validation into nis-br-method-review
Reviewer of new method nisBr, removing extra spaces. Fixes jquery-validation#2203
|
@csmendonca, By the way, you don't need to close a PR and create a new one with the new changes everytime a maintainer requested something. You can just do the changes and push your commit and they will be visible on the PR. I recommend watching this ~38 minutes lessons from Kent C. Dodds, they are the best getting started on contributing to Open Source on GitHub: https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github And, thank you again for your contribution :) |
|
Hi @Arkni, Sorry about that, it's happing because that was my first contribution to Open Source on GitHub. |
|
Ah ok. I didn't pay attention. Congratulation on your first contribution and Good luck :) |
|
Hi @Arkni, Thank you :) |
I've changed some reviews like orientation by @Arkni.
I've removed some spaces then I've chanced creation of date the new method nisBr.
Thank you!