Skip to content

Core: Fix contenteditable detection's regression introduced in #2142 #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

Arkni
Copy link
Member

@Arkni Arkni commented Nov 4, 2018

Fixes #2211
Fixes #2214
Fixes #2217
Fixes #2225
Fixes #2233

@staabm
Copy link
Member

staabm commented Nov 4, 2018

Cool. Can we get this unit tested somehow?

@Arkni
Copy link
Member Author

Arkni commented Nov 4, 2018

I think we already have some tests for contenteditable elements. One thing I can suggest in order to avoid regressions regarding IE, is for us to apply for a Saucelabs/BrowserStack open source access to use it for testing the plugin in supported IE versions and also on Safari (if it's allowed in the free plan).

@staabm
Copy link
Member

staabm commented Nov 4, 2018

Oh I see. Not sure it’s worthwhile for IE.

In case you are condfident with the patch please go ahead and merge it.
If not we can wait for som of the reporters to confirm the fix.

Thank you

@Arkni
Copy link
Member Author

Arkni commented Nov 4, 2018

It's best to wait for feedback from the reporters. I will provided the build file for them and link to it in #2211.

@PrinceCharles23
Copy link

judging from the code change this seems to do the trick. since i get the package via npm i have no clue how to test the change directly in our project...?

@staabm
Copy link
Member

staabm commented Nov 5, 2018

see #2211 (comment) on how to get the fixed version

@PrinceCharles23
Copy link

see #2211 (comment) on how to get the fixed version

this just links to the fixed file. npm would overwrite this during next build

@Arkni
Copy link
Member Author

Arkni commented Nov 18, 2018

Based on the feedback from the comunity, I am going to merge this.

@Arkni Arkni merged commit dd187b0 into jquery-validation:master Nov 18, 2018
@Arkni Arkni deleted the contenteditable-regression branch November 18, 2018 11:49
@Arkni
Copy link
Member Author

Arkni commented Nov 18, 2018

@staabm could you please release this fix in a minor version (as we also have some new validation rules added)?

You can find the changelog here: https://gist.github.com/Arkni/fc52dc8e4f5ca1ccc7ea1198b0b659a3#file-jquery-validation-changelog-1-19-0-md

Thanks :)

@staabm
Copy link
Member

staabm commented Nov 28, 2018

just published 1.19.0 with a fix for this issue.

sorry the any inconvenience this bug has caused for you guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants