Fixed value issue for radio buttons and checkboxes. Fixes #363 #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a unit test for that? |
…o mockjax service for remote testing
This was referenced Apr 17, 2012
| var type = $(element).attr('type'), | ||
| val = $(element).val(); | ||
|
|
||
| if( type === 'radio' || type === 'checkbox' ) { |
There was a problem hiding this comment.
Should be if (, also wrong in the if below, let's fix both. I had started to fix that, but -- see below.
|
🎶 PING |
|
Landed in 5893087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for values of checkboxes and radio buttons that are checked. Before the behavior was to send the first element of the group's value, regardless of whether or not it was checked.