Various fixes #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 10, 2011 08:37
OctetString can be split into a Sequence of OctetStrings. Merge them back before passing to setEncData().
|
Thanks! It would be nice if you provide tests for each fix. Can you create that? |
|
Can we get this merged in? It fixes things for me as well. |
|
@matthauck Nice, would you please give me a PKCS7 file that you use for confirmation? I can write tests and merge if I have a concrete example. |
matthauck
added a commit
to matthauck/jruby-ossl
that referenced
this pull request
May 5, 2012
For pull request jruby#9
matthauck
added a commit
to matthauck/jruby-ossl
that referenced
this pull request
May 5, 2012
For pull request jruby#9
|
any hope this might get pulled in? |
|
We also depend on these changes. How can we help to get these fixes pulled in? |
|
It'd be really nice to get these for jruby 1.7.1, now that we do not have the option of keeping these fixes of ours in a jruby-ossl fork -- it now requires a whole jruby fork which will be more difficult to maintain. |
|
Sweet! |
jedld
pushed a commit
to jedld/jruby
that referenced
this pull request
Jan 3, 2014
…re not imported correctly The case to handle content which has been encapsulated in a sequence has been in place already but wasn't implemented. The fix is inspired by Pull Request: jruby/jruby-ossl#9. The test case includes PKCS7 samples to showcase the issue. Credit goes to Jason Franklin [https://github.com/jamuc] for helping with the samples and the fix in general. Conflicts: test/externals/ruby1.9/openssl/test_pkcs7.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes bug-fixes and implementation of an unimplemented method.