Skip to content

Conversation

lxyu
Copy link
Contributor

@lxyu lxyu commented Jul 7, 2014

as discussed in #16

The bool useage is unlikely to be broken since if some_col_value equals if bool(some_col_value), but it exposes the raw data from mysql, which is more suitable for a replication lib.

@@ -62,9 +62,6 @@ def _read_column_data(self, null_bitmap):
values[name] = struct.unpack("<B", self.packet.read(1))[0]
else:
values[name] = struct.unpack("<b", self.packet.read(1))[0]

if column.type_is_bool:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about just handling the conversion here? The problem is that, the event does not carry the information that the original source column was a TINYINT(1). So you cannot do the conversion in the app just my looking at the event.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now.

bjoernhaeuser added a commit that referenced this pull request Jul 8, 2014
remove bool conversion
@bjoernhaeuser bjoernhaeuser merged commit db88361 into julien-duponchelle:master Jul 8, 2014
@julien-duponchelle julien-duponchelle added this to the 0.4 milestone Jul 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants