expose primay_keys info for row based events #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I am fine with that, will merge it when we finished #65 |
|
👍 I'm fine too |
|
Hm, PRIMARY KEYs could be more than one column. Is this addressed? Could not spot it :) |
in favor of sqlalchemy's primary_key definition style
| @@ -3,12 +3,21 @@ | |||
|
|
|||
| class Table(object): | |||
| def __init__(self, column_schemas, table_id, schema, table, columns): | |||
| primary_key = [c.data["name"] for c in columns if c.data["is_primary"]] | |||
There was a problem hiding this comment.
There may be multiple primary keys or none primary key here, so the final primary_key can either be str or tuple.
I convert it to tuple here so it's not mutable.
|
It should be fixed now. Please review it again, thanks. |
|
👍 |
|
@noplay shall we merge it? |
|
@lxyu You can make a new pull request in which you add yourself to the contributors list |
|
@bjoernhaeuser I'm already added. The "Lx Yu" is me ;) |
|
okay :) thats good to know :) |
|
Yeah we can merge it :) |
julien-duponchelle
added a commit
that referenced
this pull request
Jul 9, 2014
expose primay_keys info for row based events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a 2nd PR continues on the previous one.
This PR will expose primary keys info in row-based events, so we may only listen/publish the primary key values.