-
Notifications
You must be signed in to change notification settings - Fork 1.9k
restrict sh version #2746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict sh version #2746
Conversation
keep sh version under 2.0 as default behaviour was switched
Hi @HyTurtle ! Can you please explain why this is needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explaining!
Let's wait for the CI pipeline to complete, but LGTM.
I guess we should have an emergency release this weekend.
I will then open an issue to remind us that sh.Command
usage should be migrated to be future-proof.
Sounds like a plan. closes #2745 |
* Update `pydantic` recipe There is [incompatibility](huggingface/transformers#8638) between python > 3.6 and package `dataclasses`. This error was happening after my compilations: `AttributeError: module 'typing' has no attribute '_ClassVar'` The fix is removing `dataclasses` from `python_depends`. I also updated the pydantic version to the newest release `1.10.4`, it can be checked [here](https://github.com/pydantic/pydantic/releases) and its url. I already compiled my app after applying these changes, and the compilation is working successfully again. * Restrict sh version to sh>=1.10, <2.0 (#2746) keep sh version under 2.0 as default behaviour was switched * Update CHANGELOG.md and update version to 2023.02.10 --------- Co-authored-by: Filipe Marchesini <filipe.marchesini@gmail.com> Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com> Co-authored-by: HyTurtle <81598434+HyTurtle@users.noreply.github.com>
keep sh version under 2.0 as default behaviour was switched
keep sh version under 2.0 as default behaviour was switched
keep sh version under 2.0 as default behaviour was switched
Restrict sh version to sh>=1.10, <2.0 (kivy#2746) keep sh version under 2.0 as default behaviour was switched
⬆️ Bump sh module to v2, refs #2746
keep sh version under 2.0 as default behaviour was switched