Skip to content

Enabling android-21 builds #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2015
Merged

Enabling android-21 builds #410

merged 1 commit into from
Sep 12, 2015

Conversation

dl1ksv
Copy link
Contributor

@dl1ksv dl1ksv commented Jul 7, 2015

This patch enables python to be build for android-21 and fixes the problems for using gcc >=4.8, too

@inclement
Copy link
Member

Thanks for this patch, it looks good but I guess someone should test it before merging - I'll try to do it soon if nobody else does as I'll need to address the archs thing anyway for the p4a revamp.

About the arch, is the move to armeabi-v7a only an official change in android 5.0? I didn't know that, is there a doc page about it?

@dl1ksv
Copy link
Contributor Author

dl1ksv commented Jul 7, 2015

Without the arch change I get
/opt/android-ndk/platforms/android-21/arch-arm/usr/include/machine/cpu-features.h:52:6: error: #error Unknown or unsupported ARM architecture

error Unknown or unsupported ARM architecture

  ^

/home/schroer/python-for-android/src/jni/../jni/jpeg/jddctmgr.c:31:8: warning: #warning "ANDROID_ARMV6_IDCT is disabled" [-Wcpp]
#warning "ANDROID_ARMV6_IDCT is disabled"
^

I tested with the compass example on an nexus 7.

@inclement
Copy link
Member

That's interesting, I'll check it at the time. I guess it should be okay though, my understanding was that most devices support it now and maybe if you target that api they must support it.

There might be an issue with ctypes, I remember a mention that it didn't work with v7a compilation, though that may be out of date or refer to something slightly different. Just noting it here for reerence.

@thopiekar
Copy link
Contributor

+1 for this pull 💃

@inclement
Copy link
Member

I'll merge this, sorry for the delay, I was hoping someone who knows more about it could try it. Since it's currently broken with that api, I guess it's fine. I'm still concerned about the ctypes thing, has anyone happened to try it?

inclement added a commit that referenced this pull request Sep 12, 2015
Enabling android-21 builds
@inclement inclement merged commit e406180 into kivy:master Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants