[revamp] Undefine HAVE_FTIME for Android API > 19 #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sys/timeb.h header was removed in Android 21, because this header and the ftime function were removed from the POSIX 2008 specification. (Info reference: https://rbcommons.com/s/OpenH264/r/683/diff/1/ )
inclement
added a commit
that referenced
this pull request
Sep 12, 2015
[revamp] Undefine HAVE_FTIME for Android API > 19
|
Super, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sys/timeb.hheader was removed in Android 21, because this header and theftimefunction were removed from the POSIX 2008 specification.(Info reference: https://rbcommons.com/s/OpenH264/r/683/diff/1/ )
Closes #261, and replaces #410. The only difference is that in #410 the
#undefis surrounded by an#ifdef ANDROID, which I didn't think was necessary (because this is only ever going to be patched for Android, because...python-for-android), but I can add it if desired.