Remove deprecated kubectl exec command execution without dash #125437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/triage accepted |
|
/label tide/merge-method-squash |
|
LGTM label has been added. Git tree hash: c1f58669e2b5606bac9becc4ecde4ee6f802d388
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vinayakankugoyal
pushed a commit
to vinayakankugoyal/kubernetes
that referenced
this pull request
Jun 28, 2024
…etes#125437) * Remove deprecated kubectl exec command execution without dash * Use command execution with dash in kubectl exec * Modify unit tests to only use command after dash
|
Changelog suggestion -Removing deprecated kubectl exec [POD] [COMMAND]
+Removed the ability to run `kubectl exec [POD] [COMMAND]` (without a `--` separator).
+The `--` separator has been recommended since the Kubernetes v1.18 release, which
+also deprecated the legacy way of invoking `kubectl exec`.Aside: We never formally deprecated the old way, but I can see that the code has been printing warnings saying that we did. |
harpreet9ja
pushed a commit
to harpreet9ja/kubernetes
that referenced
this pull request
Jun 30, 2024
…etes#125437) * Remove deprecated kubectl exec command execution without dash * Use command execution with dash in kubectl exec * Modify unit tests to only use command after dash
YamasouA
pushed a commit
to YamasouA/kubernetes
that referenced
this pull request
Jul 24, 2024
…etes#125437) * Remove deprecated kubectl exec command execution without dash * Use command execution with dash in kubectl exec * Modify unit tests to only use command after dash
10 tasks
jdomeracki-coder
added a commit
to coder/coder
that referenced
this pull request
Aug 4, 2025
Current example fails since kubectl version 1.31: ```sh $ kubectl exec -it deployment/coder /bin/bash -n coder error: exec [POD] [COMMAND] is not supported anymore. Use exec [POD] -- [COMMAND] instead ``` The legacy syntax was removed in: kubernetes/kubernetes#125437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
kubectl exec [POD] [COMMAND]execution functionality was deprecated nearly 5 years ago by #88460 and it is suggested to usekubectl exec [POD] -- [COMMAND]instead.This PR removes this functionality by returning an error.
Does this PR introduce a user-facing change?