always pull pause image for eviction tests #133349
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
@kannon92: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/sig node /test pull-crio-cgroupv2-node-e2e-eviction |
f8dd567 to
e83e581
Compare
|
/test pull-crio-cgroupv2-node-e2e-eviction |
This seems to fix the problem. There are other failures in eviction that we have not yet solved. But at least this solves the other failures related to pause. |
| Name: podName, | ||
| Image: imageutils.GetPauseImageName(), | ||
| Name: podName, | ||
| ImagePullPolicy: "Always", |
There was a problem hiding this comment.
Always seems a bit aggressive. I would expect IfNotPresent will work
There was a problem hiding this comment.
Looking at other images in eviction, they were using Always. If you want this, can we do this as one fix rather than one-offs?
There was a problem hiding this comment.
Here is the follow up. #133359
SergeyKanzhelev
approved these changes
Aug 1, 2025
|
LGTM label has been added. Git tree hash: a995189fb59311c9d4f71da935f3e7e087ca86b2
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel I would like to make a change like this once and see the impact. I don't think this should block this PR. |
|
@kannon92: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Which issue(s) this PR is related to:
Fixes #133348
Special notes for your reviewer:
See the issue for RCA.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: