e2e: node: cpumanager: cleanup and tidification before test replacement #133462
+879
−748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 11 10:25:10 UTC 2025. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9d9f8a7 to
5d641f0
Compare
Is not ideal to heve utilities source file or packages, because these tend to be unfocused and attract unstructured code, easily leading to a kitchesink approach. So, let's start cleaning up by splitting the utilities we have to deal with kubelet config in its own source file, lacking bandwidth now for deeper refactorings. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
A lot ofe2e_node tests need to re-learn machine HW properties to check the correctness of the behavior. Over time, we start using these utilities among different test groups (e.g. memory manager tests use cpu manager tests utilites). So let's de-entangle this state by moving the shared utilities in a separate util file. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
Push more utilities from cpu manager tests to util.go. This time there is not a clear (or big enough) them for this set of shared code blocks. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
Since is now all about criprozy, rename utils_linux.go to better express the purpose. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
We're nearing the planned replacement of old cpumanager tests with new ones, so move the remaining utilities which we will keep using with the new codebase. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
The topology manager tests wants to run a subset of cpumanager tests while checking numa alignment. We should eventually rewrite these bits to reuse the new and cleaner rewritten cpu manager tests. For the time being, we move the shared bits in the topology manager tests, so we are now enabled to remove the remaining obsolete cpu manager tests with the rewritten ones. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
5d641f0 to
e839ada
Compare
|
/test |
|
@ffromani: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-kubernetes-node-kubelet-serial-topology-manager |
fix linter suggestions. Signed-off-by: Francesco Romani <fromani@redhat.com>
|
/test pull-kubernetes-node-kubelet-serial-topology-manager |
|
the topology-manager lane seems to have failed in teardown |
|
/test pull-kubernetes-node-kubelet-serial-topology-manager |
|
/triage accepted priority set by the fact we need to complete this work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Final cleanup before we can replace the old cpumanager tests with the rewritten ones. This is needed to bring much needed cleanup in the general area and to minimize the logic changes in the final PR
(xref: #132498 (comment))
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Previous work
Does this PR introduce a user-facing change?