I think that you should create some tests.
Check first it'll fail and then try apply your fix.

Thanks for your help!

For sure, but i need some help to start it.

On /tests where is the correct class to inset my assertions? Laravel doesn't have Request tests?

__isset is supposed to return a boolean value, but you appear to be returning other types of values?

Yeah, you're right i haven't check return type from __isset before. I'' fix it.

bool isset ( mixed $var [, mixed $... ] ) http://php.net/isset

public bool __isset ( string $name ) http://php.net/manual/en/language.oop5.overloading.php

@kneipp current commit will not check exactly if $key isset. Currently it'll always returns true because you are testing if a existent paramenter exists.

You should check from where __get() get data, then check if the container isset on __isset().

I'll tell more in next...

    /**
     * Get an input element from the request.
     *
     * @param  string  $key
     * @return mixed
     */
    public function __get($key)
    {
        $all = $this->all();
        if (array_key_exists($key, $all)) {
            return $all[$key];
        } else {
            return $this->route($key);
        }
    }

It call first $this->all(), then it check if $key exists in $all, else, it'll returns the $this->route($key). This last one will be the problem here.

In first case, you can use the __get() implementation like:

    public function __isset($key)
    {
        $all = $this->all();
        if (array_key_exists($key, $all)) {
            return true; // modified
        } else {
            // ... need do something more here...
            return ...;
        }

        return false; // added
    }

@rentalhost I have tested current commit with $request->title on controller:
var_dump($request->title) => string(4) "adaa"
var_dump(empty($request->title)) => bool(false)
var_dump(empty($request->title2)) => bool(true) // Dont exists

@kneipp For original commit it'll works, but not was implemented correctly, basically you copy/paste the __get(), but currently it'll fail. Note: it'll works for empty(), because __isset() will always returns true, but it'll fail if you do: isset($request->title2) (should returns false, but will returns true, instead).

@rentalhost does this make sense or can be broken?

    public function __isset($key)
    {
        $all = $this->all();

        if (array_key_exists($key, $all)) {
            return true;
        }
        return false;
    }

@kneipp It make sense in this specific case, but you can't ignore that __get() does too, it'll call $this->route() and you need check what it mean. I really don't know.

I'm working on this fix. When I get at home I do a pull request.

I guess it's ok now.

You forget to check the route parameters that can be returned by __get too.