Preload the System\Error class #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find. Thanks! |
taylorotwell
added a commit
that referenced
this pull request
Jun 10, 2011
Preload the System\Error class
stephenfrank
pushed a commit
to stephenfrank/laravel
that referenced
this pull request
Aug 11, 2012
Refix unit testing for Laravel
taylorotwell
pushed a commit
that referenced
this pull request
May 28, 2013
This was referenced Sep 14, 2014
This was referenced Mar 24, 2016
gdiggs
added a commit
to codeclimate-testing/laravel
that referenced
this pull request
Feb 14, 2017
Fix unused variable issue in Code Climate
vortechron
pushed a commit
to vortechron/laravel
that referenced
this pull request
Oct 3, 2017
Update database.php
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
SETUP - Pulling recent changes into descubraomundo fork
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
Italian translation
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
Updated path for latest cross-env version
krisanalfa
added a commit
to krisanalfa/laravel
that referenced
this pull request
Apr 11, 2018
taylorotwell
pushed a commit
that referenced
this pull request
Jul 31, 2018
Added Webdock.io to sponsors list
jradtilbrook
pushed a commit
to jradtilbrook/laravel
that referenced
this pull request
Apr 7, 2019
Add HealthEngine defaults/customisations
biddqb
added a commit
to biddqb/laravel-jenkins
that referenced
this pull request
Jan 12, 2021
arnoldyonata
referenced
this pull request
in arnoldyonata/crm-backend
Oct 17, 2022
…eleton Feature/crm customer skeleton
sl0wik
added a commit
to sl0wik/laravel
that referenced
this pull request
Oct 4, 2023
Customized file paths
drewmw5
added a commit
to drewmw5/laravel
that referenced
this pull request
Nov 3, 2023
updated .env files
HabZsolt
pushed a commit
to HabZsolt/laravel
that referenced
this pull request
Sep 25, 2024
maddios
pushed a commit
to genvideo/laravel
that referenced
this pull request
May 28, 2025
Fix PR alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I autoload in some external library code which hits a compile-time warning (happened to be a parent-child typehint mismatch but that's not relevant here) the error handler fires but autoload is at best finicky and at worst nonfunctional during error/exception handling. Without the preload my compile-time warning turns into an out-of-memory runaway and segfault.
Preloading the class forces it to exist ahead of time and ensures proper, immediate handling. A similar pattern occurs in Zend Framework which loads in possible exceptions 'just in case'.