Ignore empty validation rules #708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a validator rule is empty, i.e.: "required|".
|
Don't really like to put in "babysitter" features like this. Thanks for alerting us to the error though! |
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
Apply fixes from StyleCI
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Jan 29, 2024
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally created a validation rule, like so: 'required|', and got an error (see below) from Laravel because there is no second rule after the pipe character. This patch makes Laravel ignore empty rules, since there is no harm in doing so.
Unhandled Exception
Message:
Method [] does not exist.
Location:
/laravel/validator.php on line 1066
Stack Trace:
#0 /laravel/validator.php(186): Laravel\Validator->call('validate', Array)
#1 /laravel/validator.php(186): Laravel\Validator->validate('password_confir...', 'asd', Array, Object(Laravel\Validator))
#2 /laravel/validator.php(161): Laravel\Validator->check('password_confir...', '')
#3 /laravel/validator.php(147): Laravel\Validator->valid()
#4 /laravel/validator.php(137): Laravel\Validator->invalid()
#5 /application/controllers/user.php(41): Laravel\Validator->fails()
#6 [internal function]: User_Controller->post_create()
#7 /laravel/routing/controller.php(323): call_user_func_array(Array, Array)
#8 /laravel/routing/controller.php(283): Laravel\Routing\Controller->response('create', Array)
#9 /laravel/routing/controller.php(165): Laravel\Routing\Controller->execute('create', Array)
#10 /laravel/routing/route.php(153): Laravel\Routing\Controller::call('user@(:1)', Array)
#11 /laravel/routing/route.php(124): Laravel\Routing\Route->response()
#12 /laravel/laravel.php(125): Laravel\Routing\Route->call()
#13 /public/index.php(34): require('/larave...')
#14 {main}