Added the method 'is' to request.php #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a better idea. Thinking of how Wordpress allow you to check what page/url you are in, we could have the option of dynamic finders too, like so: |
|
Ah, I just merged it! :) ... feel free to send me another pull request after you work on it some more. |
|
It would also be nice to have some way of handling routes like /user/(:any)... I guess named routes could cover you there too! I think this whole feature probably needs to work using named routes. |
|
Thanks for improving it :) |
|
No problem. Do you want me to look into adding the named routes feature? Thanks for the great idea! |
|
Sure :) Thanks! |
|
This feature has been added! :) |
|
Yeah, was just testing it! It's working beautifully here :) |
This was referenced Sep 14, 2014
sl0wik
added a commit
to sl0wik/laravel
that referenced
this pull request
Oct 4, 2023
Google Cloud Storage as default file storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it would be useful to have a method that checks the uri and returns true or false. So we don't need extra code when views are shared by many routes.
Let me know what do you think of this :)