👍

Big 👍 from me. I always use the full class names in my code anyway.

:( this going to make evaluating badly written package slightly harder for me.

Mior, can you go into more detail on this?

On 30 Aug 2014, at 18:48, Mior Muhammad Zaki notifications@github.com wrote:

:( this going to make evaluating badly written package slightly harder for me.

—
Reply to this email directly or view it on GitHub.

@driesvints it was a sarcastic comment. I do actually welcome this, and if anyone insist to have it he/she still are able to do so by editing the config, it just not bundle in by default.

Package that have use Eloquent instead of use Illuminate\Database\Eloquent\Model indicate poor understanding on how package should be written and will not work if you use Slim (or anything else) with Eloquent (using capsule).

@crynobone I completely agree. I see such use statements in packages all the time, and the really bug me.

Yes I agree, +1 for making my package less relevant ;) Especially because you can't really do anything with traits in the helper, and they are a bit weird to class alias.

One example that I personally experience recently, we had one proof of concept app using CodeIgniter with multiple illuminate components which was working nicely for us. However we need to include a Barcode integration to it and we did find one laravel package that allow that, normally you can just manually load the package by mimicking the service provider but in this case the package include use Str which was not available in our case and we had to create a class alias manually to solve it. If the package has instead use Illluminate\Support\Str we wouldn't need any hack.

+1 from me, too.
Am 30.08.2014 19:41 schrieb "Mior Muhammad Zaki" notifications@github.com:

One example that I personally experience recently, we had one proof of
concept app using CodeIgniter with multiple illuminate components which was
working nicely for us. However we need to include a Barcode integration to
it and we did find one laravel package that allow that, normally you can
just manually load the package by mimicking the service provider but in
this case the package include use Str which was not available in our case
and we had to create a class alias manually to solve it. If the package has
instead use Illluminate\Support\Str we wouldn't need any hack.

—
Reply to this email directly or view it on GitHub
#2980 (comment).

@crynobone ok, lol sorry. Didn't get that.

I've now removed the Str alias as well. I agree with you guys. It shouldn't be in there as default. People can always add it if they like. Perhaps we should make a note in the docs?

I've also removed the FormRequest class. Taylor: is that ok?

Updated commit message:

Eloquent and Seeder were used to extend from which is a bad practice.
The SoftDeletingTrait should be imported just like the UserTrait and the RemindableTrait.
Str was also removed because it's just a shortcut for the namespace. People can always re-add it if they like. We also get autocompletion this way.
I wasn't entirely sure what FormRequest was doing here but I have a feeling it's going to be used for the same reasons as one of the above classes. So I removed it as well.

👍