Skip to content

Develop #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 127 commits into from
Closed

Develop #3043

wants to merge 127 commits into from

Conversation

flavio-portela
Copy link

Why does the function's documentation of the constructors in all the clases have return void? The contructors doesn't return anything
contructor

@cpass78
Copy link

cpass78 commented Sep 26, 2014

Void is nothing so they return nothing.
On Sep 26, 2014 4:30 PM, "Flavio Portela" notifications@github.com wrote:

Why does the function's documentation of the constructors in all the
clases have return void? The contructors doesn't return anything


You can merge this Pull Request by running

git pull https://github.com/laravel/laravel develop

Or view, comment on, or merge it at:

#3043

Commit Summary
Point at 4.3.
Move the environment settings into their own file.
Working on compile config file.
Move storage out of app directory.
Tweak default SQLite database.
Rename commands directory.
Fix autoload map.
Working on overall app structure.
Continuing to work on structure.
Remove class loader from aliases.
Merging structure branch.
Work on inspiring command.
Fix a few things.
Merge branch 'master' into develop
Working on default route setup.
Working on new provider and aliases.
Adding requests directory.
Working on new directory structure.
Remove accidental dependency.
Add src path.
Working on directory structure. Event provider.
Rename core directory.
Make a few tweaks to providers.
Update the GitIgnore file.
Use a standard routes file by default.
Pull routes after booting application.
Add more paths.
Working on app structure.
Unused path.
Namespace change.
Autoload the console.
Remove none existing files being referred in .gitignore
Working on the default app structure.
Update paths.
Fix compile file.
Renaming folders.
Rename.
Merge pull request #2967 from crynobone/patch/update-gitignore
Fix gitignore files.
Mega work on structure.
Set console command name.
Update controller namespace.
Move PHPUnit to require-dev and fixes directory references to tests.
Merge pull request #2970 from crynobone/patch/phpunit
Add note.
Use facades.
Tweak where views and lang files are located.
Change how controller is aliased.
Fix path.
Simplify .gitignore's .env
Remove remote provider.
Remove some service providers and aliases.
Fixing a few things. Namespace configuration.
Fix slashes.
Remove unnecessary alias.
Merge pull request #2974 from jpavon/patch-2
Merge branch 'master' into develop
Add language line.
Merge branch 'master' into develop
Merge branch 'master' into develop
Fix contracts.
Add filesystem configuration.
Typo.
Convert configuration PHP 5.4 arrays.
Convert arrays.
Working on a few changes.
Simplify providers.
Use App facade.
Convert language PHP 5.4 arrays.
Convert language PHP 5.4 arrays.
Convert language PHP 5.4 arrays.
Fix doc blocks.
Use injection here. Blah, can't decide.
Settle on Facades in service providers.
Set root controller namespace.
Import facade.
Extend model.
Use working directory.
Remove a few providers.
Remove classes from aliases list
Merge pull request #2980 from driesvints/feature/dont-extend-class-aliases
Merge pull request #2979 from serhatdurum/develop
Fix parameters for the AuthFilter.
Update the docblock for the CsrfFilter.
Spellcheck
Merge pull request #2981 from jasonlewis/fix/auth-csrf-filters
Updated Eloquent to Eloquent\Model
[bug] Auth filter still redirects to /login not auth/login
Working on read me.
Merge pull request #2991 from alnutile/patch-3
Merge pull request #2985 from brnlbs/develop
Merge pull request #2983 from ajschmaltz/patch-1
Fix readme.
Remove extra lines.
Fix dependency
Merge pull request #3011 from tyloo/patch-1
Fix typo on config namespaces.controller to namespace.controllers
Merge pull request #3021 from hernandev/develop
Make Artisan service provider be deferred.
Embrace contracts.
Added missing new lines at eof
Removed a trailing space
Merge pull request #3031 from GrahamCampbell/cs
Do some more injection on filters.
More work on filters.
Merge branch 'develop' of github.com:laravel/laravel into develop
Use tabs, always.
Merge pull request #3034 from crynobone/patch/tabs
Simplifying some filters.
Missing Authenticator import in GuestFilter
Convert last long notation array to short notation
Let router be inherited by route script.
Inject router into before method.
Merge pull request #3035 from danharper/patch-1
Merge pull request #3036 from lucasmichot/short-notation-array
Use helpers.
File Changes
M .gitignore (4)
D CONTRIBUTING.md (3)
A app/Console/InspireCommand.php (44)
R app/Http/Controllers/HomeController.php (12)
A app/Http/Filters/AuthFilter.php (60)
A app/Http/Filters/BasicAuthFilter.php (35)
A app/Http/Filters/CsrfFilter.php (26)
A app/Http/Filters/GuestFilter.php (39)
A app/Http/Filters/MaintenanceFilter.php (39)
R app/Http/Requests/.gitkeep (0)
R app/Http/routes.php (5)
A app/Providers/AppServiceProvider.php (31)
A app/Providers/ArtisanServiceProvider.php (35)
A app/Providers/ErrorServiceProvider.php (40)
A app/Providers/FilterServiceProvider.php (37)
A app/Providers/LogServiceProvider.php (28)
A app/Providers/RouteServiceProvider.php (44)
R app/User.php (11)
D app/config/compile.php (18)
D app/config/remote.php (59)
D app/controllers/BaseController.php (18)
D app/database/production.sqlite (0)
D app/filters.php (90)
D app/start/artisan.php (13)
D app/start/global.php (81)
D app/start/local.php (3)
D app/storage/.gitignore (1)
D app/storage/cache/.gitignore (2)
D app/views/emails/auth/reminder.blade.php (14)
M bootstrap/autoload.php (32)
A bootstrap/environment.php (18)
M bootstrap/paths.php (26)
M bootstrap/start.php (6)
M composer.json (20)
R config/app.php (108)
R config/auth.php (14)
R config/cache.php (12)
A config/compile.php (42)
R config/database.php (34)
A config/filesystems.php (69)
R config/local/app.php (4)
R config/local/database.php (16)
R config/mail.php (6)
A config/namespaces.php (39)
R config/packages/.gitkeep (0)
R config/queue.php (34)
R config/services.php (16)
R config/session.php (6)
R config/testing/cache.php (4)
R config/testing/session.php (4)
R config/view.php (6)
R config/workbench.php (4)
R database/.gitignore (0)
R database/migrations/.gitkeep (0)
R database/seeds/.gitkeep (0)
R database/seeds/DatabaseSeeder.php (5)
M phpunit.xml (2)
M readme.md (10)
R resources/lang/en/pagination.php (4)
R resources/lang/en/reminders.php (4)
R resources/lang/en/validation.php (31)
A resources/views/emails/auth/reminder.blade.php (15)
R resources/views/hello.php (0)
R storage/cache/.gitignore (0)
R storage/logs/.gitignore (0)
A storage/meta/.gitignore (4)
R storage/sessions/.gitignore (0)
R storage/views/.gitignore (0)
R storage/work/.gitkeep (0)
R tests/ExampleTest.php (0)
R tests/TestCase.php (2)
Patch Links:
https://github.com/laravel/laravel/pull/3043.patch
https://github.com/laravel/laravel/pull/3043.diff


Reply to this email directly or view it on GitHub.

@jrahmy
Copy link

jrahmy commented Sep 26, 2014

😆

These questions are best asked at the forums: http://laravel.io/forum

@jmshal
Copy link

jmshal commented Sep 28, 2014

You made a bit of a mistake here, but to answer your question; It's a Laravel convention, I don't think there is any other reason.

@GrahamCampbell
Copy link
Member

That's what void means. Please close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet