Skip to content

Use PHP 5.5 ::class property in config files #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2015
Merged

Use PHP 5.5 ::class property in config files #3403

merged 1 commit into from
Jun 5, 2015

Conversation

RomainLanz
Copy link

See #3402

@GrahamCampbell
Copy link
Member

This looks much better to me. :)

@RomainLanz
Copy link
Author

Do we also change auth.php and services.php file for App\User?

@nWidart
Copy link
Contributor

nWidart commented Jun 5, 2015

Hehe, I was about to submit same PR. 😄

I'd do the same for auth.php.

@RomainLanz
Copy link
Author

@nWidart You can also do the same for services.php.

Send a PR to my fork. I'll squash it.

taylorotwell added a commit that referenced this pull request Jun 5, 2015
Use PHP 5.5 ::class property in config files
@taylorotwell taylorotwell merged commit 86e53af into laravel:develop Jun 5, 2015
@RomainLanz RomainLanz deleted the patch-1 branch June 5, 2015 13:09
@nWidart nWidart mentioned this pull request Jun 5, 2015
@EspadaV8
Copy link

EspadaV8 commented Jun 7, 2015

Wow, gone for a day and miss out on all the action. Thanks for this @RomainLanz this does look a lot better (don't know why I didn't do this in the first place).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants